feat(asgi): Apply data_collection filtering to URL query strings#6832
feat(asgi): Apply data_collection filtering to URL query strings#6832ericapisani wants to merge 2 commits into
Conversation
Filter query string parameters in the ASGI request data and span attributes according to the data_collection.url_query_params config, mirroring the existing WSGI behaviour. Falls back to the legacy send_default_pii check when data_collection is not enabled. Refs PY-2583 Refs #6743
Codecov Results 📊✅ 93419 passed | ⏭️ 6302 skipped | Total: 99721 | Pass Rate: 93.68% | Execution Time: 332m 24s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2479 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.67% 89.72% +0.05%
==========================================
Files 193 193 —
Lines 24004 24119 +115
Branches 8340 8420 +80
==========================================
+ Hits 21526 21640 +114
- Misses 2478 2479 +1
- Partials 1387 1391 +4Generated by Codecov Action |
There was a problem hiding this comment.
Same q as on one of the PRs before: can we make these a bit less unit-testy and set up an ASGI app instead, like the tests after these? (I suspect this might also already be part of a future PR, feel free to disregard in that case.)
There was a problem hiding this comment.
I'll confirm if I've already taken care of it in that later PR in the stack I mentioned elsewhere and address it there if I haven't already
There was a problem hiding this comment.
Confirmed that as of the most recent branch in the stack (pr 13), these were all updated to use ASGI apps in their tests
2 participants
Filter query string parameters in the ASGI request data and span
attributes according to the data_collection.url_query_params config,
mirroring the existing WSGI behaviour. Falls back to the legacy
send_default_pii check when data_collection is not enabled.
Refs PY-2583
Refs #6743